Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate maximum number of metadata that can be set on an entity #82

Open
viniarck opened this issue Mar 24, 2022 · 0 comments
Open

Validate maximum number of metadata that can be set on an entity #82

viniarck opened this issue Mar 24, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@viniarck
Copy link
Member

viniarck commented Mar 24, 2022

Currently, there's no upperbound when setting a metadata attribute of a GenericEntity (LInk, Switch, Interface), this can lead to massive objects stored and even vulnerability for unauthenticated endpoints. Since this data will also be written on Mongo it's desirable to validate both how large this object is and how many keys.

Maybe we can limit up to 200 metadata keys for now, and also measure on average the expected size of that object, let me know if that sounds reasonable for the number of metadata keys we'll have in prod, what do you think?

@viniarck viniarck added the enhancement New feature or request label Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant