Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom tag range on vlan pool migration script #214

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

italovalcy
Copy link

Closes #213

Summary

This Pull request adds support for custom tag range on vlan pool migration script.

Local Tests

N/A

End-to-End Tests

N/A

@italovalcy italovalcy requested a review from a team as a code owner September 25, 2024 00:00
Copy link
Member

@viniarck viniarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this enhancement with the CUSTOM_TAG_RANGE @italovalcy.

If you also want this script on version 2023.2.0 we might need to also backport there, otherwise if you think it's fine to get it from master then no need. It's up to you.

Copy link

@Alopalao Alopalao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@italovalcy
Copy link
Author

Great to have this enhancement with the CUSTOM_TAG_RANGE @italovalcy.

If you also want this script on version 2023.2.0 we might need to also backport there, otherwise if you think it's fine to get it from master then no need. It's up to you.

It is fine to get from master! Thanks Vinicius!

@italovalcy italovalcy merged commit 0392a20 into master Sep 25, 2024
1 check passed
@italovalcy italovalcy deleted the fix/issue_213 branch September 25, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for custom vlan range on vlan_pool migration script
3 participants