Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update certificates renewal time before expiration #1350

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

dixudx
Copy link
Contributor

@dixudx dixudx commented Sep 18, 2024

Related issue

Proposed Changes

fixing inconsistent documentation on certificates renewal time before expiration.

https://github.com/kyverno/kyverno/blob/8fec1ad76431a084cc62fedefaaa24a4a96a8953/cmd/kyverno/main.go#L298

flagset.DurationVar(&renewBefore, "renewBefore", 15*24*time.Hour, "The certificate renewal time before expiration")

Checklist

  • I have read the contributing guidelines.
  • I have inspected the website preview for accuracy.
  • [] I have signed off my issue.

Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @dixudx , thanks!

@realshuting realshuting added this to the 1.13.0 milestone Sep 18, 2024
@realshuting realshuting merged commit 874e6e6 into kyverno:main Sep 18, 2024
5 of 6 checks passed
@dixudx dixudx deleted the fix-certs-expiry branch September 18, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants