Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Deprecate Some File Extensions #79

Closed
1 task done
l-zeuch opened this issue Aug 20, 2023 · 2 comments · Fixed by #80
Closed
1 task done

Proposal: Deprecate Some File Extensions #79

l-zeuch opened this issue Aug 20, 2023 · 2 comments · Fixed by #80
Labels
area/ftdetect affecting filetype detection status/triage default label before it is marked as bug or something else type/enhancement New feature or request
Milestone

Comments

@l-zeuch
Copy link
Owner

l-zeuch commented Aug 20, 2023

Description

Currently, we support a plethora of file extensions, namely the
following:

" Detect our 'own' extensions, which are usually used by a
" vast majority of the userbase.
au BufRead,BufNewFile *.yag setfiletype yagpdbcc
au BufRead,BufNewFile *.yagpdb setfiletype yagpdbcc
au BufRead,BufNewFile *.yagcc setfiletype yagpdbcc
au BufRead,BufNewFile *.yag-cc setfiletype yagpdbcc
au BufRead,BufNewFile *.yagpdbcc setfiletype yagpdbcc
au BufRead,BufNewFile *.yagpdb-cc setfiletype yagpdbcc

This is certainly a lot, and potentially way too much. There are also
some potential issues with a hyphenated file extension (just a gut
feeling, I haven't tested it) — moreover, long file extensions are just
really weird.

Solution

I propose we drop support for yagpdb, yagpdbcc, yag-cc, and
yagpdb-cc in favour of just yag and maybe yagcc. The option to
override tmpl and go.tmpl should be kept, though, as
yagpdb-cc/yagpdb-cc uses the latter one (for whatever reason, Joe
doesn't remember why).

Obviously this will be a breaking change, and thus needs proper
announcement, at the very least inside the commit message. Keeping this
issue open for a while will also help with that.

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@l-zeuch l-zeuch added type/enhancement New feature or request status/triage default label before it is marked as bug or something else area/ftdetect affecting filetype detection labels Aug 20, 2023
l-zeuch added a commit that referenced this issue Aug 20, 2023
Drop support for unnecessary file extensions, as they are too long
and/or confusing / redundant.

Closes #79

Breaking Change:
Support for the following file extensions will be dropped:
* yagpdb
* yagpdbcc
* yag-cc
* yagpdb-cc

Signed-off-by: Luca Zeuch <l-zeuch@email.de>
l-zeuch added a commit that referenced this issue Aug 20, 2023
Drop support for unnecessary file extensions, as they are too long
and/or confusing / redundant.

Closes #79

Breaking Change:
Support for the following file extensions will be dropped:
* yagpdb
* yagpdbcc
* yag-cc
* yagpdb-cc

Signed-off-by: Luca Zeuch <l-zeuch@email.de>
@l-zeuch
Copy link
Owner Author

l-zeuch commented Aug 20, 2023

For the record, I've implemented the proposed changes in #80.

If there are any comments on this proposal, please post them here, not on the PR.

@LRitzdorf
Copy link
Collaborator

Sounds good to me! I do agree that having so many supported extensions is a bit weird.

l-zeuch added a commit that referenced this issue Aug 21, 2023
* ftdetect: drop support for unnecessary file exts

Drop support for unnecessary file extensions, as they are too long
and/or confusing / redundant.

Closes #79

Breaking Change:
Support for the following file extensions will be dropped:
* yagpdb
* yagpdbcc
* yag-cc
* yagpdb-cc

Signed-off-by: Luca Zeuch <l-zeuch@email.de>

* readme: satisfy markdown lint

Signed-off-by: Luca Zeuch <l-zeuch@email.de>

---------

Signed-off-by: Luca Zeuch <l-zeuch@email.de>
@l-zeuch l-zeuch modified the milestones: Done, Backlog Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ftdetect affecting filetype detection status/triage default label before it is marked as bug or something else type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants