repo: general housekeeping #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Zeuch <l-zeuch@email.de>
Rename the old generate target to "completion", thus being more clear about what it does. In a similar vein, we introduce a new meta-target "generate", that runs both syntax and completion targets. Signed-off-by: Luca Zeuch <l-zeuch@email.de>
There's now Neovim 0.10.0, so add the version prior to that to the version matrix. Rename the workflow files genfuncs and generate to be a bit more telling about what they contain. Tell lytfs about our GITHUB_TOKEN, thereby authenticating with the GitHub API. Although the unauthenticated ratelimit is quite lenient considering that Workflows take a bit to fire and run, it's better to be safe, especially when quick-firing multiple runs. Checkout the repository with an SSH deploy key, in hopes to cause less headaches when trying to push regenerated syntax defs and suchlike to a PR. Attempt to cache the build Neovim and Vim binaries, hopefully speeding up workflow runs. Not quite sure if it will work, but worst case scenario is actions/cache emitting a warning, as far as I can tell. Signed-off-by: Luca Zeuch <l-zeuch@email.de>
actions/cache wants a key to store the cache under. Add one. Signed-off-by: Luca Zeuch <l-zeuch@email.de>
It appears as if the setup-vim action is not quite compatible with caching, or we do not fully understand how it functions yet. For now, we will remove the cache attempt and just cope with the longer build times. Signed-off-by: Luca Zeuch <l-zeuch@email.de>
Run the `generate` target instead of the `syntax` target to lessen the noise in the git log, though we squash it anyway. Signed-off-by: Luca Zeuch <l-zeuch@email.de>
LRitzdorf
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some general housekeeping tasks that need be done in light of a few new things.
Summary:
We now attempt to cache build Neovim and Vim binaries, hopefully speeding up workflow runs in long-standing PRsNot anymore, see 74837a9generatetarget tocompletionto better reflect what it is doinggeneratethat runs both syntax and completion genTerms