Skip to content
This repository has been archived by the owner on Jul 3, 2019. It is now read-only.

Some tests missing files to check #9

Open
Zearin opened this issue Oct 12, 2012 · 4 comments
Open

Some tests missing files to check #9

Zearin opened this issue Oct 12, 2012 · 4 comments

Comments

@Zearin
Copy link
Contributor

Zearin commented Oct 12, 2012

In test/test_package.py, before the unittest class is declared, there’s a bunch of variables defined with names like VCARDS_INVALID_TIME, VCARDS_INVALID_URI, and so forth.

Most of these reference files in the test/ directory, demonstrating that the tests should fail when given an invalid vCard file.

However, several of these definitions don’t list any vCard files at all. I presume this means that these error cases are not being tested.

@l0b0
Copy link
Owner

l0b0 commented Oct 12, 2012

Yes, those are placeholders/reminders to add vCards with such properties to test more thoroughly.

@l0b0 l0b0 closed this as completed Oct 12, 2012
@Zearin
Copy link
Contributor Author

Zearin commented Oct 12, 2012

Wait, you closed the issue?

Shouldn't it stay open until those files are added?

@l0b0
Copy link
Owner

l0b0 commented Oct 13, 2012

My bad...

@l0b0 l0b0 reopened this Oct 13, 2012
@Zearin
Copy link
Contributor Author

Zearin commented Oct 13, 2012

:P

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants