-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement error handling and return it to analytics #31
feat: Implement error handling and return it to analytics #31
Conversation
DS-122 Implement logging and update Notion page
Please implement the logging for at lease one exemplary module, sending the data to the crawling finished endpoint in the Analytics endpoint. Please ping us when you are done so we can apply this for all other modules as well. Also, please ensure the logging Notion page is up-to-date. |
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
I fully tested these changes with the la-famiglia-jst2324/parma-analytics#54 and I had some fixes in analytics PR as well 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only one suggestion for refactoring
Motivation
Check Notion and Linear
Handle specific errors and inform Analytics about it
Refer the Analytics PR fix: Sourcing trigger flow errors parma-analytics#54
Changes
task_id
is adapted to/companies
endpoint/crawling-finished
task_id
and error list is returned via/crawling-finished
Checklist
!
(e.g.feat!: Update endpoint
)