-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add Continuous Deployment & terraform #5
Conversation
META-13 Sourcing deployment
Currently blocked by Sourcing Team and their respective design decisions. Firebase is blocked by #Meta-12 Please stay in touch with them and once they have agreed on sth. you can start deploying the respective services. Expectations:
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
@robinholzi Finally the last thing is that i need to add secret environment variables into this and all other mining repositories, how can i find them? I also have a comment about this topic in here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks very good to me, the CI/CD worksflows (.github/workflows
) are missing, right? Otherwise we won't ever use the terraform code :)
@egekocabas Let me know once this is ready for review (just transition the PR to review mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super solid, thanks for taking the time to implement (and understand my terraform setup)🚀
Just one thing to check before merging!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the effort required for deploying this👍 I hope it was at least rewarding in terms of learning experience :)
Motivation
We need to deploy our data mining modules to the GCP.
Changes
Checklist
!
(e.g.feat!: Update endpoint
)