Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add Continuous Deployment & terraform #5

Merged
merged 23 commits into from
Dec 2, 2023

Conversation

egekocabas
Copy link
Contributor

@egekocabas egekocabas commented Nov 27, 2023

Motivation

We need to deploy our data mining modules to the GCP.

Changes

  • terraform files are added
  • deploy.yml pipeline created
  • Dockerfile is created
  • release.yml pipeline deleted
  • GITHUB_TOKEN is used inside pipeline and terraform

Checklist

  • added myself as assignee
  • correct reviewers
  • descriptive PR title using conventional commits.
  • description explains the motivation and details of the changes
  • tests cover my changes
  • documentation is updated
  • CI is green
  • breaking changes are discussed with the team and documented in the PR title ! (e.g. feat!: Update endpoint)

@egekocabas egekocabas self-assigned this Nov 27, 2023
Copy link

linear bot commented Nov 27, 2023

META-13 Sourcing deployment

Currently blocked by Sourcing Team and their respective design decisions.

Firebase is blocked by #Meta-12

Please stay in touch with them and once they have agreed on sth. you can start deploying the respective services.

Expectations:

  • Deployments to Firebase (cloud functions) / GCP (app service, …) / Apify depending on technical feasibility and desires of sourcing team
  • respective CI pipelines for production, staging (and a local dev environment).
    • deploy on release to prod
    • deploy on merge to main to staging
    • local setup + docs
  • Documentation! (preferably in READMEs, mermaid can help to visualise dependencies, workflows etc.)
  • If feasible within this sprint assist sourcing team with local setup

@github-actions github-actions bot added the build label Nov 27, 2023
Copy link

github-actions bot commented Nov 27, 2023

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
67 55 82% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 8bb42cf by action🐍

@egekocabas
Copy link
Contributor Author

@robinholzi
Also in the analytics repository there are lock files under prod, staging and state folders. Do I need to create them? Because i searched a little bit and found out that they are created after terraform init or deploy, i am not really sure what to do about it actually.

Finally the last thing is that i need to add secret environment variables into this and all other mining repositories, how can i find them? I also have a comment about this topic in here.

terraform/prod/main.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@robinholzi robinholzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks very good to me, the CI/CD worksflows (.github/workflows) are missing, right? Otherwise we won't ever use the terraform code :)

terraform/module/main.tf Show resolved Hide resolved
terraform/prod/main.tf Outdated Show resolved Hide resolved
terraform/prod/main.tf Outdated Show resolved Hide resolved
@robinholzi
Copy link
Contributor

@egekocabas Let me know once this is ready for review (just transition the PR to review mode)

@egekocabas egekocabas marked this pull request as ready for review November 30, 2023 22:29
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
terraform/prod/main.tf Show resolved Hide resolved
Copy link
Contributor

@robinholzi robinholzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super solid, thanks for taking the time to implement (and understand my terraform setup)🚀

Just one thing to check before merging!

.github/workflows/deploy.yml Show resolved Hide resolved
.dockerignore Outdated Show resolved Hide resolved
Copy link
Contributor

@robinholzi robinholzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the effort required for deploying this👍 I hope it was at least rewarding in terms of learning experience :)

@egekocabas egekocabas merged commit 266dd6a into main Dec 2, 2023
4 checks passed
@egekocabas egekocabas deleted the egekocabas/meta-13-sourcing-deployment branch December 2, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants