Skip to content

Commit

Permalink
refactor: Remove Firebase Adminsdk (#17)
Browse files Browse the repository at this point in the history
  • Loading branch information
egekocabas authored Dec 27, 2023
1 parent ac31141 commit 7cf976b
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 26 deletions.
1 change: 0 additions & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ defaults:
shell: bash -el {0}

env:
TF_VAR_FIREBASE_ADMINSDK_CERTIFICATE: ${{ github.event_name == 'release' && secrets.PROD_FIREBASE_ADMINSDK_CERTIFICATE || secrets.STAGING_FIREBASE_ADMINSDK_CERTIFICATE}}
TF_VAR_ANALYTICS_BASE_URL: ${{ github.event_name == 'release' && vars.PROD_ANALYTICS_BASE_URL || vars.STAGING_ANALYTICS_BASE_URL}}
TF_VAR_REDDIT_API_KEY: ${{ secrets.REDDIT_API_KEY }}
TF_VAR_REDDIT_BASE_URL: ${{ vars.REDDIT_BASE_URL }}
Expand Down
1 change: 0 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ WORKDIR /app

COPY --chown=$MAMBA_USER:$MAMBA_USER parma_mining /app/parma_mining

ENV FIREBASE_ADMINSDK_CERTIFICATE=$FIREBASE_ADMINSDK_CERTIFICATE
ENV REDDIT_API_KEY=$REDDIT_API_KEY
ENV REDDIT_BASE_URL=$REDDIT_BASE_URL
ENV REDDIT_CLIENT_ID=$REDDIT_CLIENT_ID
Expand Down
4 changes: 0 additions & 4 deletions terraform/module/service.tf
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ resource "google_cloud_run_service" "parma_mining_reddit_cloud_run" {
ports {
container_port = 8080
}
env {
name = "FIREBASE_ADMINSDK_CERTIFICATE"
value = var.FIREBASE_ADMINSDK_CERTIFICATE
}
env {
name = "REDDIT_API_KEY"
value = var.REDDIT_API_KEY
Expand Down
6 changes: 0 additions & 6 deletions terraform/module/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@ variable "region" {
type = string
}

variable "FIREBASE_ADMINSDK_CERTIFICATE" {
description = "value"
type = string
sensitive = true
}

variable "REDDIT_API_KEY" {
description = "value"
type = string
Expand Down
1 change: 0 additions & 1 deletion terraform/prod/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ module "main" {
env = "prod"
project = local.project
region = local.region
FIREBASE_ADMINSDK_CERTIFICATE = var.FIREBASE_ADMINSDK_CERTIFICATE
REDDIT_API_KEY = var.REDDIT_API_KEY
REDDIT_BASE_URL = var.REDDIT_BASE_URL
REDDIT_CLIENT_ID = var.REDDIT_CLIENT_ID
Expand Down
6 changes: 0 additions & 6 deletions terraform/prod/variables.tf
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
variable "FIREBASE_ADMINSDK_CERTIFICATE" {
description = "value"
type = string
sensitive = true
}

variable "REDDIT_API_KEY" {
description = "value"
type = string
Expand Down
1 change: 0 additions & 1 deletion terraform/staging/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ module "main" {
env = "staging"
project = local.project
region = local.region
FIREBASE_ADMINSDK_CERTIFICATE = var.FIREBASE_ADMINSDK_CERTIFICATE
REDDIT_API_KEY = var.REDDIT_API_KEY
REDDIT_BASE_URL = var.REDDIT_BASE_URL
REDDIT_CLIENT_ID = var.REDDIT_CLIENT_ID
Expand Down
6 changes: 0 additions & 6 deletions terraform/staging/variables.tf
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
variable "FIREBASE_ADMINSDK_CERTIFICATE" {
description = "value"
type = string
sensitive = true
}

variable "REDDIT_API_KEY" {
description = "value"
type = string
Expand Down

0 comments on commit 7cf976b

Please sign in to comment.