Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Setup logging #18

Merged
merged 3 commits into from
Jan 10, 2024
Merged

fix: Setup logging #18

merged 3 commits into from
Jan 10, 2024

Conversation

egekocabas
Copy link
Contributor

@egekocabas egekocabas commented Dec 27, 2023 •
edited
Loading

Motivation

META-68
Add logging setup.

Also supports different log levels for different environments.

Changes

Checklist

  • added myself as assignee
  • correct reviewers
  • descriptive PR title using conventional commits.
  • description explains the motivation and details of the changes
  • tests cover my changes
  • my functions are fully typed
  • documentation is updated
  • CI is green
  • breaking changes are discussed with the team and documented in the PR title ! (e.g. feat!: Update endpoint)

@egekocabas egekocabas self-assigned this Dec 27, 2023
@github-actions github-actions bot added the fix label Dec 27, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2023 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
199 125 63% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
parma_mining/reddit/api/main.py 67% 🟢
parma_mining/reddit/client.py 54% 🟢
TOTAL 60% 🟢

updated for commit: 6cd3ec7 by action🐍

@egekocabas egekocabas marked this pull request as ready for review December 27, 2023 22:49
@egekocabas egekocabas merged commit 5f364b3 into main Jan 10, 2024
4 checks passed
@egekocabas egekocabas deleted the fix-logging branch January 10, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinholzi robinholzi Awaiting requested review from robinholzi robinholzi is a code owner

@Constantin343 Constantin343 Awaiting requested review from Constantin343 Constantin343 is a code owner

Assignees

@egekocabas egekocabas

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@egekocabas