Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix normalization map #32

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix: Fix normalization map #32

merged 1 commit into from
Jan 31, 2024

Conversation

OguzKaanImamoglu
Copy link
Contributor

Motivation

Small mistake in the normalization map was blocking to way to Firestore.

Changes

Normalization map is fixed, Source field is corrected.

Checklist

  • added myself as assignee
  • correct reviewers
  • descriptive PR title using conventional commits.
  • description explains the motivation and details of the changes
  • tests cover my changes
  • my functions are fully typed
  • documentation is updated
  • CI is green
  • breaking changes are discussed with the team and documented in the PR title ! (e.g. feat!: Update endpoint)

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
323 262 81% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
parma_mining/reddit/api/main.py 88% 🟢
parma_mining/reddit/client.py 35% 🟢
parma_mining/reddit/model.py 100% 🟢
parma_mining/reddit/normalization_map.py 100% 🟢
TOTAL 81% 🟢

updated for commit: d8d99c7 by action🐍

@egekocabas egekocabas merged commit e389681 into main Jan 31, 2024
4 checks passed
@egekocabas egekocabas deleted the fix-norm-map branch January 31, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants