Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add bucket CRUD frontend #46

Merged
merged 40 commits into from
Dec 13, 2023
Merged

feat: Add bucket CRUD frontend #46

merged 40 commits into from
Dec 13, 2023

Conversation

Frens1999
Copy link
Contributor

@Frens1999 Frens1999 commented Dec 1, 2023

Motivation

We needed the bucket page for the users to check their buckets and search for others.
We needed to create a bucket, edit a bucket, remove a bucket, and share a bucket.
We needed a service for buckets so we could reuse the methods there.
We needed a function in the utils so we could use fetch with the access token.

Changes

The bucket page with my bucket and other buckets is done. The search filter is done as well.
Creation of bucket
Edit bucket is done.
Share bucket is done.
Delete bucket is done.
Bucket service is done.
FetchWithAuth function is done so we can send access token to the headers.

About this PR

The delete bucket should be only on My buckets, but there isn’t an endpoint for my buckets yet and I left it for demonstration.
New pagination is needed (this one is temporary and a little buggy). Backend will provide after the midterm.
Need to discuss how to share the bucket. For now is only an endpoint to add and update one by one but maybe for later we need a list of invitees to share.
When adding a bucket we need to send a list of companies and not just one.(Now the solution is with only one company, the first one of the list)
.
When in a specific bucket page we can not edit companies and add more for now but those will be added later after the midterm.
Some code that is commented is related to the changes that we need to do,above.
Keep this in mind while you are reviewing this PR.
Closes FA-53

Checklist

  • added myself as assignee
  • correct reviewers
  • descriptive PR title using conventional commits.
  • description explains the motivation and details of the changes
  • tests cover my changes
  • documentation is updated
  • CI is green
  • breaking changes are discussed with the team and documented in the PR title ! (e.g. feat!: Update endpoint)

All buckets page

Bucket Card

Add .data dir in git ignore
Copy link

linear bot commented Dec 1, 2023

FA-46 Buckets Page

Implement the buckets page with mock data

  • Include the important CRUD operations
  • create all relevant components

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
parma-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 7:06pm

@Frens1999 Frens1999 changed the title Search input for buckets Buckets page Dec 1, 2023
@Frens1999 Frens1999 self-assigned this Dec 1, 2023
@Frens1999 Frens1999 changed the title Buckets page feat/Create-Buckets-page Dec 1, 2023
@Frens1999 Frens1999 changed the title feat/Create-Buckets-page feat/Create-buckets-page Dec 1, 2023
@Frens1999 Frens1999 added the enhancement New feature or request label Dec 1, 2023
@Frens1999 Frens1999 changed the title feat/Create-buckets-page feat/Create buckets page Dec 1, 2023
@Frens1999 Frens1999 marked this pull request as draft December 1, 2023 16:38
@robinholzi
Copy link
Contributor

Thanks for contributing to ParmaAI! 👋🏼

Please use PR titles according to Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details

@Frens1999 fyi.

@robinholzi robinholzi changed the title feat/Create buckets page feat: Create buckets page Dec 1, 2023
@Frens1999
Copy link
Contributor Author

Thanks for contributing to ParmaAI! 👋🏼
Please use PR titles according to Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details

@Frens1999 fyi.

It is not ready for PR. Please next time do not push into my branch because I am working and not I can not pull because I also merged main some minutes ago. @robinholzi

Copy link
Contributor

@saiyam3243 saiyam3243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes are visible now, @HamzaChx create backlogs for remaining functionalities left in this PR

src/context/auth.tsx Outdated Show resolved Hide resolved
src/app/buckets/[id]/page.tsx Show resolved Hide resolved
src/app/buckets/add-bucket/page.tsx Outdated Show resolved Hide resolved
src/context/auth.tsx Outdated Show resolved Hide resolved
src/types/popup.ts Outdated Show resolved Hide resolved
src/utils/fetchWithAuth.ts Outdated Show resolved Hide resolved
@robinholzi robinholzi changed the title feat: All buckets page, edit bucket, create bucket, delete bucket, share bucket and create fetchWithAuth function feat: Add bucket CRUD frontend Dec 13, 2023
@Frens1999 Frens1999 merged commit 9e80b50 into main Dec 13, 2023
8 checks passed
@Frens1999 Frens1999 deleted the feature/fa-46-buckets-page branch December 13, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants