-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add bucket CRUD frontend #46
Conversation
All buckets page Bucket Card Add .data dir in git ignore
FA-46 Buckets Page
Implement the buckets page with mock data
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Frens1999 fyi. |
It is not ready for PR. Please next time do not push into my branch because I am working and not I can not pull because I also merged main some minutes ago. @robinholzi |
…st2324/parma-web into feature/fa-46-buckets-page
Remove badges from card (for now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes are visible now, @HamzaChx create backlogs for remaining functionalities left in this PR
…a-jst2324/parma-web into feature/fa-46-buckets-page
Motivation
We needed the bucket page for the users to check their buckets and search for others.
We needed to create a bucket, edit a bucket, remove a bucket, and share a bucket.
We needed a service for buckets so we could reuse the methods there.
We needed a function in the utils so we could use fetch with the access token.
Changes
The bucket page with my bucket and other buckets is done. The search filter is done as well.
Creation of bucket
Edit bucket is done.
Share bucket is done.
Delete bucket is done.
Bucket service is done.
FetchWithAuth function is done so we can send access token to the headers.
About this PR
The delete bucket should be only on My buckets, but there isn’t an endpoint for my buckets yet and I left it for demonstration. New pagination is needed (this one is temporary and a little buggy). Backend will provide after the midterm. Need to discuss how to share the bucket. For now is only an endpoint to add and update one by one but maybe for later we need a list of invitees to share. When adding a bucket we need to send a list of companies and not just one.(Now the solution is with only one company, the first one of the list) .
When in a specific bucket page we can not edit companies and add more for now but those will be added later after the midterm.
Some code that is commented is related to the changes that we need to do,above.
Keep this in mind while you are reviewing this PR.
Closes FA-53
Checklist
!
(e.g.feat!: Update endpoint
)