-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Settings and profile page #60
Conversation
FA-52 Implement Settings & Profile UI
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!! Just some minor adjustments that can be made
Someone is attempting to deploy this pull request to the la-famiglia-jst2324 Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, nice work!
Some minor things can still be improved but we can do that in a follow up PR with the missing changes (that will be added to the backlog).
To be done:
- changing profile picture
- handling the user profile form (saving the data once the endpoints exist)
- Email input in the profile form should be disabled, instead only show the current email.
- Full name should be displayed as the placeholder of the form (can be fetched from the user from AuthContext)
- Replacing the password inputs with a redirect to the "forgot password" page
- Implement report config (once endpoint are there)
Requested changes have been applied
} | ||
|
||
// Validate the form data here (if necessary) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it required or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can open quick patch PR to address these small things. Apart from that, good job :)
const file = event.target.files[0] | ||
// setSelectedFile(file); // Save the file to the component's state | ||
|
||
// Here you might want to update the UI to show the file name or preview the image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't we do that here? Or is this just a ChatGPT comment that we forgot to remove?
export default AuthCheck(ProfilePage) | ||
|
||
// function setSelectedFile(file: File) { | ||
// throw new Error('Function not implemented.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented out code 😨
formData.append('file', file) | ||
|
||
try { | ||
// Post the form data to your API route for file upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this?
Motivation
For the visualization of settings and profile page
Changes
implement the logic
Checklist
!
(e.g.feat!: Update endpoint
)