Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Settings and profile page #60

Merged
merged 8 commits into from
Dec 13, 2023

Conversation

saiyam3243
Copy link
Contributor

@saiyam3243 saiyam3243 commented Dec 6, 2023

Motivation

For the visualization of settings and profile page

Changes

implement the logic

Checklist

  • added myself as assignee
  • correct reviewers
  • descriptive PR title using conventional commits.
  • description explains the motivation and details of the changes
  • tests cover my changes
  • documentation is updated
  • CI is green
  • breaking changes are discussed with the team and documented in the PR title ! (e.g. feat!: Update endpoint)

@saiyam3243 saiyam3243 requested a review from a team December 6, 2023 22:14
@saiyam3243 saiyam3243 self-assigned this Dec 6, 2023
Copy link

linear bot commented Dec 6, 2023

FA-52 Implement Settings & Profile UI

  • Implement the Settings page to add the reports configuration and API keys
  • Adjust the profile page on figma
  • Implement the profile page

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
parma-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 0:43am

@saiyam3243 saiyam3243 marked this pull request as draft December 6, 2023 22:15
Copy link
Contributor

@HamzaChx HamzaChx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! Just some minor adjustments that can be made

src/app/globals.css Outdated Show resolved Hide resolved
src/app/profile/page.tsx Outdated Show resolved Hide resolved
src/app/settings/page.tsx Outdated Show resolved Hide resolved
src/app/globals.css Outdated Show resolved Hide resolved
src/app/settings/page.tsx Outdated Show resolved Hide resolved
Copy link

vercel bot commented Dec 12, 2023

Someone is attempting to deploy this pull request to the la-famiglia-jst2324 Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

@github-actions github-actions bot added the enhancement New feature or request label Dec 12, 2023
Copy link
Contributor

@HamzaChx HamzaChx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, nice work!
Some minor things can still be improved but we can do that in a follow up PR with the missing changes (that will be added to the backlog).
To be done:

  • changing profile picture
  • handling the user profile form (saving the data once the endpoints exist)
  • Email input in the profile form should be disabled, instead only show the current email.
  • Full name should be displayed as the placeholder of the form (can be fetched from the user from AuthContext)
  • Replacing the password inputs with a redirect to the "forgot password" page
  • Implement report config (once endpoint are there)

src/app/profile/page.tsx Outdated Show resolved Hide resolved
src/app/settings/page.tsx Show resolved Hide resolved
src/components/MainLayout.tsx Show resolved Hide resolved
src/types/bucket.ts Show resolved Hide resolved
@HamzaChx HamzaChx dismissed robinholzi’s stale review December 13, 2023 09:00

Requested changes have been applied

@HamzaChx HamzaChx merged commit aeebc49 into main Dec 13, 2023
6 checks passed
@HamzaChx HamzaChx deleted the feature/fa-52-implement-settings-profile-ui branch December 13, 2023 09:00
email
}

// Validate the form data here (if necessary)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it required or not?

Copy link
Contributor

@robinholzi robinholzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can open quick patch PR to address these small things. Apart from that, good job :)

const file = event.target.files[0]
// setSelectedFile(file); // Save the file to the component's state

// Here you might want to update the UI to show the file name or preview the image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't we do that here? Or is this just a ChatGPT comment that we forgot to remove?

export default AuthCheck(ProfilePage)

// function setSelectedFile(file: File) {
// throw new Error('Function not implemented.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code 😨

formData.append('file', file)

try {
// Post the form data to your API route for file upload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants