Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3-labgrid: use a SRCBRANCH variable in the git URL #52

Merged
merged 1 commit into from
Jun 20, 2024
Merged

python3-labgrid: use a SRCBRANCH variable in the git URL #52

merged 1 commit into from
Jun 20, 2024

Conversation

jluebbe
Copy link
Member

@jluebbe jluebbe commented Jun 20, 2024

This makes it easier to switch the branch together with the SRCREV using .bbappend or .conf files.

@jluebbe
python3-labgrid: use a SRCBRANCH variable in the git URL
dc18169 
This makes it easier to switch the branch together with the SRCREV using
.bbappend or .conf files.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
@jluebbe jluebbe requested a review from Emantor June 20, 2024 08:33
ejoerns
ejoerns reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@ejoerns ejoerns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it makes sense for the release recipe, but shouldn't hurt either. 😏

I wonder if overriding from global configuration works without using ?=?

@jluebbe jluebbe mentioned this pull request Jun 20, 2024
Merged
@jluebbe
Copy link
Member Author

jluebbe commented Jun 20, 2024 •
edited
Loading

Not sure if it makes sense for the release recipe, but shouldn't hurt either. 😏

I wonder if overriding from global configuration works without using ?=?

Many recipes in meta-oe use = and it's consistent SRCREV.

@ejoerns
Copy link
Contributor

ejoerns commented Jun 20, 2024

Not sure if it makes sense for the release recipe, but shouldn't hurt either. 😏
I wonder if overriding from global configuration works without using ?=?

Many recipes in meta-oe use = and it's consistent SRCREV.

I just checked oe-core where ?= is used in most cases, but indeed it works with = when using recipe-specific overrides (which is the only sensible use case for global configuration I guess), thus fine for me.

@jluebbe
Copy link
Member Author

jluebbe commented Jun 20, 2024

The CI failure already exists on master and seems unrelated to this PR.

@jluebbe jluebbe merged commit 0ae5d95 into labgrid-project:master Jun 20, 2024
1 of 2 checks passed
@jluebbe jluebbe deleted the srcbranch branch June 20, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejoerns ejoerns ejoerns left review comments

@Emantor Emantor Emantor approved these changes

Assignees

@Emantor Emantor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jluebbe @ejoerns @Emantor