Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scarthgap: update labgrid master version and add support for gRPC #61

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

hnez
Copy link
Contributor

@hnez hnez commented Oct 22, 2024

This is a backport of #58 to the scarthgap branch.

Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also fix the commit prefixes to meta-labgrid, also a master commit reference would be nice to be included in the commits, git cherry-pick -x provides this.

These are required by the new grpc-based labgrid versions.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
(cherry picked from commit 3ab5a0e)
This marks a breaking change compared to the previous release version,
as master now uses grpc instead of crossbar to communicate between the
client, coordinator and exporters.

This means all of these components need to be updated to the grpc-based
versions at the same time.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
(cherry picked from commit 9a3750c)
@hnez
Copy link
Contributor Author

hnez commented Oct 22, 2024

We should also fix the commit prefixes to meta-labgrid,

Oh. Did not notice that. We do not have meta… prefixes in other commits in this repo, so I have removed them.

also a master commit reference would be nice to be included in the commits, git cherry-pick -x provides this.

Cool. Did not know that. I've re-picked the two commits.

@Emantor Emantor merged commit e8bc593 into labgrid-project:scarthgap Oct 22, 2024
2 checks passed
@hnez hnez deleted the scarthgap-grpc branch October 22, 2024 06:58
@Emantor
Copy link
Member

Emantor commented Oct 22, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants