Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the ant.d tooltip is covered in modal with mwc drawer #1928

Merged
merged 2 commits into from
Sep 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion react/src/components/DefaultProviders.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -95,42 +95,42 @@
return [lang] as const;
};

const DefaultProviders: React.FC<DefaultProvidersProps> = ({
children,
value,
styles,
shadowRoot,
dispatchEvent,
}) => {
const cache = useMemo(() => createCache(), []);
const [lang] = useCurrentLanguage();
const themeConfig = useCustomThemeConfig();

const componentValues = useMemo(() => {
return {
value,
dispatchEvent,
moveTo: (path, params) => {
dispatchEvent('moveTo', { path, params: params });
},
} as WebComponentContextType;
}, [value, dispatchEvent]);
return (
<>
{RelayEnvironment && (
<RelayEnvironmentProvider environment={RelayEnvironment}>
<React.StrictMode>
<style>
{styles}
{rawFixAntCss}
</style>
<QueryClientProvider client={queryClient}>
<ShadowRootContext.Provider value={shadowRoot}>
<WebComponentContext.Provider value={componentValues}>
<ConfigProvider
// @ts-ignore
getPopupContainer={(triggerNode) => {
return shadowRoot;
return triggerNode?.parentNode || shadowRoot;

Check warning on line 133 in react/src/components/DefaultProviders.tsx

View workflow job for this annotation

GitHub Actions / Coverage annotations (🧪 jest-coverage-report-action)

🧾 Statement is not covered

Warning! Not covered statement

Check warning on line 133 in react/src/components/DefaultProviders.tsx

View workflow job for this annotation

GitHub Actions / Coverage annotations (🧪 jest-coverage-report-action)

🌿 Branch is not covered

Warning! Not covered branch

Check warning on line 133 in react/src/components/DefaultProviders.tsx

View workflow job for this annotation

GitHub Actions / Coverage annotations (🧪 jest-coverage-report-action)

🌿 Branch is not covered

Warning! Not covered branch
}}
//TODO: apply other supported locales
locale={'ko' === lang ? ko_KR : en_US}
Expand Down
6 changes: 6 additions & 0 deletions react/src/fix_antd.css
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,13 @@
}
}

/* fix: fixed column shadow display outside of a table wrapper */
.ant-table-wrapper {
border-radius: 8px 8px 0 0;
overflow: hidden;
}

/* fix: the tooltip does not appear in the `<Form.Item tooltip={'something'}` when the popup container is a parent node of the trigger node. */
.ant-form-item-label {
overflow: unset !important;
}
Loading