Add an 'Import from hugging face' modal #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.66% (-0.01% 🔻) |
141/5293 |
| 🔴 | Branches | 2.87% (-0% 🔻) |
101/3521 |
| 🔴 | Functions | 1.53% (-0.01% 🔻) |
27/1760 |
| 🔴 | Lines | 2.54% (-0.01% 🔻) |
132/5192 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / ImportFromHuggingFaceModal.tsx |
0% | 0% | 0% | 0% |
Test suite run success
51 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from f0f1be8
yomybaby
approved these changes
Jul 5, 2024
agatha197
force-pushed
the
feature/add-import-from-hugging-face-modal
branch
from
fb9f567
to
7fd4eff
Compare
agatha197
force-pushed
the
feature/add-import-from-hugging-face-modal
branch
from
f0f1be8
to
d07378c
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.46% (-0.01% 🔻) |
337/6169 |
| 🔴 | Branches | 5.05% (-0% 🔻) |
214/4236 |
| 🔴 | Functions | 3.1% (-0.01% 🔻) |
63/2029 |
| 🔴 | Lines | 5.36% (-0.01% 🔻) |
323/6025 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / ImportFromHuggingFaceModal.tsx |
0% | 0% | 0% | 0% |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from c333321
agatha197
force-pushed
the
feature/add-import-from-hugging-face-modal
branch
3 times, most recently
from
7f49f61
to
77422f2
Compare
This was referenced Sep 19, 2024
agatha197
force-pushed
the
feature/add-import-from-hugging-face-modal
branch
from
77422f2
to
f9c9efd
Compare
yomybaby
requested changes
Sep 20, 2024
agatha197
force-pushed
the
feature/add-import-from-hugging-face-modal
branch
from
f9c9efd
to
d57d172
Compare
Merge activity
|
### TL;DR Add a new feature to import from Hugging Face in the VFolderListPage. ### What changed? 1. Modified `config.toml.sample` for indentation fix. 2. Added `ImportFromHuggingFaceModal` component to `react/src/components`. 3. Integrated `ImportFromHuggingFaceModal` in `VFolderListPage`. 4. Added new buttons and toggle functionality to `VFolderListPage.tsx`. 5. Updated language JSON files to include new translations for the Hugging Face import feature. ### How to test? 1. [Remove this line ](https://github.com/lablup/backend.ai-webui/pull/2514/files#diff-65e44191bce624d5e51a52298306cdece45d544cfb5ac1cc5fa4a202ddde6693R122) 2. Navigate to the data page. And click the model or model-store tab. 3. You can check the added modal by clicking an 'Import From Hugging Face' button. ### Screenshots   --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
feature/add-import-from-hugging-face-modal
branch
from
d57d172
to
c333321
Compare
graphite-app
bot
deleted the
feature/add-import-from-hugging-face-modal
branch
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Add a new feature to import from Hugging Face in the VFolderListPage.
What changed?
config.toml.samplefor indentation fix.ImportFromHuggingFaceModalcomponent toreact/src/components.ImportFromHuggingFaceModalinVFolderListPage.VFolderListPage.tsx.How to test?
Screenshots
Checklist: (if applicable)