feat: show confirm modal instead of popconfirm when deleting endpoint #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
agatha197
force-pushed
the
bugfix/cannot-delete-model-service-if-routing-exists
branch
from
7128c6f
to
2acc770
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.37% (-0% 🔻) |
329/6122 |
| 🔴 | Branches | 5.02% (-0% 🔻) |
211/4202 |
| 🔴 | Functions | 3.08% | 62/2013 |
| 🔴 | Lines | 5.27% (-0% 🔻) |
315/5978 |
Test suite run success
83 tests passing in 9 suites.
Report generated by 🧪jest coverage report action from f3491db
agatha197
force-pushed
the
bugfix/cannot-delete-model-service-if-routing-exists
branch
2 times, most recently
from
ac4b98b
to
0e78489
Compare
6 tasks
agatha197
changed the title
agatha197
changed the title
yomybaby
force-pushed
the
bugfix/cannot-delete-model-service-if-routing-exists
branch
from
0e78489
to
24132e9
Compare
6 tasks
yomybaby
reviewed
Sep 4, 2024
react/src/pages/EndpointListPage.tsx
Outdated
Comment on lines
369
to
375
| _.map(getDeleteRoutingIds(endpoint_id), (routing_id) => | ||
| baiSignedRequestWithPromise({ | ||
| method: 'DELETE', | ||
| url: '/services/' + endpoint_id + '/routings/' + routing_id, | ||
| client: baiClient, | ||
| }), | ||
| ), |
There was a problem hiding this comment.
Is deleting routings before deleting services required? or not? @agatha197
yomybaby
force-pushed
the
bugfix/cannot-delete-model-service-if-routing-exists
branch
2 times, most recently
from
c30caa7
to
1286ee6
Compare
yomybaby
approved these changes
Sep 4, 2024
Merge activity
|
…#2678) ### TL;DR Improved the delete functionality for endpoints in the EndpointListPage component. ### What changed? - **Replaced the Popconfirm component with a modal confirmation dialog for deleting endpoints.** - Removed the `terminatingModelService` state and directly used the row data for deletion. - Updated the error handling and success messages for the terminate mutation. - Simplified the delete button's onClick handler. ### How to test? 1. Navigate to the EndpointListPage. 2. Attempt to delete an endpoint by clicking the delete button. 3. Verify that a modal confirmation dialog appears. 4. Confirm the deletion and check if the endpoint is removed successfully. 5. Test error scenarios by mocking a failed deletion and verify error messages. ### Why make this change? This change enhances the user experience by providing a more robust and consistent deletion process. The modal confirmation offers better visibility and control over the deletion action, while the improved error handling ensures users receive accurate feedback on the operation's success or failure.
yomybaby
force-pushed
the
bugfix/cannot-delete-model-service-if-routing-exists
branch
from
1286ee6
to
f3491db
Compare
graphite-app
bot
deleted the
bugfix/cannot-delete-model-service-if-routing-exists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Improved the delete functionality for endpoints in the EndpointListPage component.
What changed?
terminatingModelServicestate and directly used the row data for deletion.How to test?
Why make this change?
This change enhances the user experience by providing a more robust and consistent deletion process. The modal confirmation offers better visibility and control over the deletion action, while the improved error handling ensures users receive accurate feedback on the operation's success or failure.