refactor: centralize resource slot type definitions and improve device metadata handling in /react
#2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.49% (+0.12% 🔼) |
337/6143 |
| 🔴 | Branches | 5.08% (+0.06% 🔼) |
214/4215 |
| 🔴 | Functions | 3.12% (+0.04% 🔼) |
63/2019 |
| 🔴 | Lines | 5.38% (+0.12% 🔼) |
323/5999 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / ResourceNumber.tsx |
21.43% (-5.24% 🔻) |
0% | 0% | 21.43% (-5.24% 🔻) |
| 🔴 | ... / ResourceAllocationFormItems.tsx |
16.33% | 11.67% (-0.1% 🔻) |
13.64% | 15.98% |
Test suite run success
85 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from d52c682
yomybaby
force-pushed
the
refactor/remove-hard-coded-resource-name
branch
from
5d3ed00
to
726b291
Compare
yomybaby
force-pushed
the
refactor/remove-hard-coded-resource-name
branch
2 times, most recently
from
a76b485
to
3086120
Compare
yomybaby
changed the title
/react
yomybaby
changed the title
/react
yomybaby
force-pushed
the
refactor/remove-hard-coded-resource-name
branch
from
3086120
to
8d61cb6
Compare
yomybaby
force-pushed
the
refactor/remove-hard-coded-resource-name
branch
2 times, most recently
from
e6cb569
to
92df5b7
Compare
Merge activity
|
…e metadata handling in `/react` (#2684) ### TL;DR Added support for dynamic accelerator types and improved resource allocation handling. ### What changed? - Introduced `ResourceSlotName` type to handle known and unknown accelerator types - Updated `ResourceTypeIcon` component to use dynamic resource slot details - Modified `ResourceAllocationFormItems` to use resource slot details for display units - Added JSON schema validation for device metadata - Implemented `isMatchingMaxPerContainer` function for flexible config matching - Updated resource limit calculations to support unknown accelerator types ### The steps to add a new accelerator type 1. Add the accelerator type to `knownAcceleratorResourceSlotNames` in `react/src/hooks/backendai.tsx`. 2. Add an icon for the new accelerator type to `resourceTypeIconSrcMap` in `react/src/components/ResourceNumber.tsx`. 3. Add new accelerator metadata to `resources/device_metadata.json`. After following only step 1, you got a TypeScript error related to step 2 and Jest test failures related to step 3. ### How to test? 1. Run the JSON schema validation test for device metadata 2. Test the resource allocation form with various accelerator types 3. Verify that unknown accelerator types are handled correctly in the UI 4. Check if the resource limits are calculated correctly for all accelerator types ### Why make this change? This change improves the flexibility and maintainability of the codebase by: 1. Supporting dynamic accelerator types without hardcoding 2. Ensuring consistency between device metadata and code 3. Improving resource limit calculations for various accelerator types 4. Enhancing the user interface to display correct units for different accelerators These improvements allow for easier addition of new accelerator types and better handling of resource allocation across different devices.
lizable
force-pushed
the
refactor/remove-hard-coded-resource-name
branch
from
92df5b7
to
d52c682
Compare
graphite-app
bot
deleted the
refactor/remove-hard-coded-resource-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added support for dynamic accelerator types and improved resource allocation handling.
What changed?
ResourceSlotNametype to handle known and unknown accelerator typesResourceTypeIconcomponent to use dynamic resource slot detailsResourceAllocationFormItemsto use resource slot details for display unitsisMatchingMaxPerContainerfunction for flexible config matchingThe steps to add a new accelerator type
knownAcceleratorResourceSlotNamesinreact/src/hooks/backendai.tsx.resourceTypeIconSrcMapinreact/src/components/ResourceNumber.tsx.resources/device_metadata.json.After following only step 1, you got a TypeScript error related to step 2 and Jest test failures related to step 3.
How to test?
Why make this change?
This change improves the flexibility and maintainability of the codebase by:
These improvements allow for easier addition of new accelerator types and better handling of resource allocation across different devices.