Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagination and filter with deferred values #2688

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Sep 4, 2024

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Sep 4, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

yomybaby commented Sep 4, 2024

@github-actions github-actions bot added the size:XL 500~ LoC label Sep 4, 2024
@yomybaby yomybaby force-pushed the feat/add-endpoint-status-filtering branch from 9c2fee6 to 9d935d3 Compare September 4, 2024 10:56
@yomybaby yomybaby force-pushed the feat/endpoint-filter-pagination-deferred-value branch from b48b679 to c8ac48e Compare September 4, 2024 10:56
@yomybaby yomybaby force-pushed the feat/add-endpoint-status-filtering branch from 9d935d3 to 0d55600 Compare September 4, 2024 11:09
@yomybaby yomybaby force-pushed the feat/endpoint-filter-pagination-deferred-value branch from c8ac48e to 95c43e8 Compare September 4, 2024 11:09
@yomybaby yomybaby force-pushed the feat/add-endpoint-status-filtering branch 2 times, most recently from d39f1dd to bda5469 Compare September 4, 2024 11:16
@yomybaby yomybaby force-pushed the feat/endpoint-filter-pagination-deferred-value branch 2 times, most recently from 4fe78b9 to a250852 Compare September 4, 2024 14:29
@yomybaby yomybaby marked this pull request as ready for review September 4, 2024 14:56
@yomybaby yomybaby changed the base branch from feat/add-endpoint-status-filtering to graphite-base/2688 September 4, 2024 14:59
@yomybaby yomybaby force-pushed the feat/endpoint-filter-pagination-deferred-value branch from 4ca2a10 to e492237 Compare September 4, 2024 15:00
@yomybaby yomybaby changed the base branch from graphite-base/2688 to main September 4, 2024 15:01
@yomybaby yomybaby force-pushed the feat/endpoint-filter-pagination-deferred-value branch 2 times, most recently from 71bf153 to 4b3f594 Compare September 4, 2024 15:03
Copy link

github-actions bot commented Sep 4, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.37% (-0% 🔻)
329/6130
🔴 Branches
5.02% (-0.01% 🔻)
211/4207
🔴 Functions
3.08% (-0% 🔻)
62/2015
🔴 Lines
5.26% (-0% 🔻)
315/5986

Test suite run success

83 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 4b3f594

@yomybaby
Copy link
Member Author

yomybaby commented Sep 4, 2024

There are several things to improve. However, since the feature that displays status based on the radio group selection is working, I will merge it. I have not confirmed the backward compatibility yet.

@yomybaby yomybaby merged commit 95093ee into main Sep 4, 2024
8 checks passed
@yomybaby yomybaby deleted the feat/endpoint-filter-pagination-deferred-value branch September 4, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant