fix: compatibility for lifecycle filter of Endpoint #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
area:lib
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.48% (-0% 🔻) |
337/6149 |
| 🔴 | Branches | 5.07% (-0% 🔻) |
214/4222 |
| 🔴 | Functions | 3.12% | 63/2021 |
| 🔴 | Lines | 5.38% (-0% 🔻) |
323/6005 |
Test suite run success
85 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from 6b90dcf
Merge activity
|
### TL;DR Added support for endpoint lifecycle stage filtering based on server version compatibility. ### What changed? - Introduced a new feature flag 'endpoint-lifecycle-stage-filter' in the backend client for version 24.03.10 and above. - Modified the EndpointListPage to conditionally render the lifecycle stage filter Radio.Group based on server support. - Adjusted the API request to include the lifecycle stage filter only when supported by the server. ### How to test? 1. Ensure you're using a backend server version 24.03.10 or higher. 2. Navigate to the Endpoint List Page. 3. Verify that the lifecycle stage filter (Active/Destroyed) is visible. 4. Test the filter by selecting different options and confirm that the endpoint list updates accordingly. 5. Check that the API requests include the lifecycle stage filter parameter. ### Why make this change? This change enables more granular filtering of endpoints based on their lifecycle stage, improving user experience and efficiency when managing endpoints. By making this feature version-dependent, it ensures compatibility with older server versions while allowing newer versions to take advantage of the enhanced filtering capabilities.
yomybaby
force-pushed
the
fix/compatibility-for-lifecycle-filter-of-endpoint
branch
from
d9227f7
to
6b90dcf
Compare
graphite-app
bot
deleted the
fix/compatibility-for-lifecycle-filter-of-endpoint
branch
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added support for endpoint lifecycle stage filtering based on server version compatibility.
What changed?
How to test?
Why make this change?
This change enables more granular filtering of endpoints based on their lifecycle stage, improving user experience and efficiency when managing endpoints. By making this feature version-dependent, it ensures compatibility with older server versions while allowing newer versions to take advantage of the enhanced filtering capabilities.