Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Session owner setting panel in Neo session launcher #2693

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Sep 5, 2024

TL;DR

Added session owner setter functionality and improved resource group selection.

image image

What changed?

  • Introduced SessionOwnerSetterCard and SessionOwnerSetterPreviewCard components for setting session owners
  • Added BAISelect component for enhanced select functionality
  • Updated ResourceGroupSelect to use project name instead of ID
  • Modified AvailableResourcesCard to use ResourceGroupSelectForCurrentProject
  • Updated SessionLauncherPage to include session owner setter for admin and superadmin roles
  • Added new words to the spell checker configuration
  • Add ErrorBoundary with empty fallback to ignore SessionLauncherValidationTour's error

How to test?

  1. Log in as an admin or superadmin user
  2. Navigate to the session launcher page
  3. Verify that the session owner setter card is visible
  4. Test the functionality of setting a session owner:
    • Enter an owner's email
    • Select an access key
    • Choose a group and resource group
  5. Confirm that the preview card updates correctly
  6. Launch a session and verify that the owner settings are applied

Why make this change?

This change enhances the session management capabilities for administrators, allowing them to launch sessions on behalf of other users.

Copy link
Member Author

yomybaby commented Sep 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @yomybaby and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the size:L 100~500 LoC label Sep 5, 2024
Copy link

graphite-app bot commented Sep 5, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@yomybaby yomybaby force-pushed the feat/session-owner-setter-in-neo branch from 57557ac to 4afce60 Compare September 9, 2024 03:31
@yomybaby yomybaby force-pushed the feat/session-owner-setter-in-neo branch from 730b466 to 70a922f Compare September 9, 2024 03:38
Copy link

github-actions bot commented Sep 9, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.43% (-0.03% 🔻)
337/6201
🔴 Branches
5.02% (-0.06% 🔻)
214/4266
🔴 Functions
3.09% (-0.02% 🔻)
63/2037
🔴 Lines
5.33% (-0.03% 🔻)
323/6056
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / SessionOwnerSetterCard.tsx
0% 0% 0% 0%
🔴
... / BAISelect.tsx
0% 0% 0% 0%

Test suite run success

90 tests passing in 11 suites.

Report generated by 🧪jest coverage report action from c8adf42

@yomybaby yomybaby marked this pull request as ready for review September 9, 2024 03:42
@yomybaby yomybaby marked this pull request as draft September 9, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant