Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use antd color token for invalid mwc-textfield theme #2704

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Sep 13, 2024

TL;DR

Updated the error color for mwc-textfield in the folder explorer component.

before after
image.png image.png

How to test?

  1. Navigate to the folder explorer component in the UI.
  2. Trigger an error state in any textfield within the component.
  3. Verify that the error color matches the --token-colorError defined in the theme.

Why make this change?

This change ensures consistency in error color representation across the application by using the predefined --token-colorError variable. It improves the visual coherence of the UI and maintains a uniform look for error states in textfields within the folder explorer component.


Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Sep 13, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ironAiken2 and the rest of your teammates on Graphite Graphite

@ironAiken2 ironAiken2 marked this pull request as ready for review September 13, 2024 04:23
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 merged commit 148593f into main Sep 19, 2024
9 checks passed
@agatha197 agatha197 deleted the fix/mwc-textfield-invalid-color branch September 19, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants