feat: fetch the Hugging Face info using a URL #2710
Merged
+326
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
This was referenced Sep 19, 2024
github-actions
bot
added
area:ux
agatha197
force-pushed
the
feature/add-enableImportFromHuggingFace-option
branch
from
3b0ef99
to
96dce7b
Compare
agatha197
force-pushed
the
feature/fetch-README-file-using-url
branch
from
428f295
to
6f06b46
Compare
agatha197
force-pushed
the
feature/add-enableImportFromHuggingFace-option
branch
from
96dce7b
to
b4b1ee2
Compare
agatha197
force-pushed
the
feature/fetch-README-file-using-url
branch
from
6f06b46
to
4779bf1
Compare
yomybaby
changed the base branch from
feature/add-enableImportFromHuggingFace-option
to
graphite-base/2710
yomybaby
force-pushed
the
graphite-base/2710
branch
from
b4b1ee2
to
be6db95
Compare
yomybaby
force-pushed
the
feature/fetch-README-file-using-url
branch
from
4779bf1
to
0364105
Compare
yomybaby
force-pushed
the
feature/fetch-README-file-using-url
branch
from
0364105
to
b577b9a
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.43% (-0.03% 🔻) |
337/6201 |
| 🔴 | Branches | 5.02% (-0.03% 🔻) |
214/4263 |
| 🔴 | Functions | 3.08% (-0.02% 🔻) |
63/2043 |
| 🔴 | Lines | 5.33% (-0.03% 🔻) |
323/6056 |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from dc76d4e
agatha197
force-pushed
the
feature/fetch-README-file-using-url
branch
from
b577b9a
to
0b96433
Compare
yomybaby
changed the title
3 tasks
2 tasks
Merge activity
|
**Changes:** This PR enhances the `ImportFromHuggingFaceModal` component with improved URL validation and model information display. Key changes include: 1. Added URL validation for Hugging Face model URLs. 2. Implemented a check button to validate and fetch model information. 3. Added display of model name and author information. 4. Integrated suspense-based loading for fetching model data. 5. Updated translations for new UI elements and error messages. **Rationale:** These changes improve the user experience when importing models from Hugging Face by providing immediate feedback on URL validity and displaying key model information. The suspense-based loading ensures a smooth user interface while fetching content. **Effects:** Users will now see immediate validation of Hugging Face URLs and get basic model information (name and author) directly in the import modal. This allows them to make more informed decisions when importing models and reduces the likelihood of errors due to invalid URLs. **How to test:** 1. Checkout core branch to `feature/get-huggingface-model-card` 2. Enable `enableImportFromHuggingFace` option in config.toml 3. Click the `Import from Hugging Face` button in Models or Model Store Tab. 4. Input any Hugging Face URL and click the "Check" button. 5. Observe the validation feedback and model information display. **Screenshots:** 
yomybaby
force-pushed
the
feature/fetch-README-file-using-url
branch
from
3d8fd90
to
dc76d4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR enhances the
ImportFromHuggingFaceModalcomponent with improved URL validation and model information display. Key changes include:Rationale:
These changes improve the user experience when importing models from Hugging Face by providing immediate feedback on URL validity and displaying key model information. The suspense-based loading ensures a smooth user interface while fetching content.
Effects:
Users will now see immediate validation of Hugging Face URLs and get basic model information (name and author) directly in the import modal. This allows them to make more informed decisions when importing models and reduces the likelihood of errors due to invalid URLs.
How to test:
feature/get-huggingface-model-cardenableImportFromHuggingFaceoption in config.tomlImport from Hugging Facebutton in Models or Model Store Tab.Screenshots: