fix: add scroll to the lablup-activity-panel #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on |
ironAiken2
force-pushed
the
fix/scroll-in-lablup-activity-panel
branch
2 times, most recently
from
74ecd2f
to
8b33779
Compare
ironAiken2
force-pushed
the
fix/scroll-in-lablup-activity-panel
branch
from
8b33779
to
675fdca
Compare
agatha197
requested changes
Sep 27, 2024
ironAiken2
force-pushed
the
fix/scroll-in-lablup-activity-panel
branch
from
675fdca
to
49e767c
Compare
Merge activity
|
### This PR resolves [giftbox#723](lablup/giftbox#723) issue  **Changes:** - Implemented `scrollableY="true"` attribute for activity panels in `BackendAIResourcePanel` and `BackendAISummary` - Enhanced `lablup-activity-panel` to improve scrolling functionality: - Added a `content` class to the inner div - Adjusted height calculations to account for header space - Implemented separate overflow settings for content area **Checklist:** - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
agatha197
force-pushed
the
fix/scroll-in-lablup-activity-panel
branch
from
49e767c
to
b5f174c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves giftbox#723 issue
Changes:
scrollableY="true"attribute for activity panels inBackendAIResourcePanelandBackendAISummarylablup-activity-panelto improve scrolling functionality:contentclass to the inner divChecklist: