Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove checking URL and add more form inputs #2714

Closed

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Sep 20, 2024

Changes:

This PR updates the ImportFromHuggingFaceModal component and related translations:

  • Simplified the form structure by removing the separate check button and combining URL validation with form submission
  • Added new form fields for "Model store folder name" and "Service name"
  • Updated URL validation to occur on form submission rather than a separate check step
  • Removed unused state variables and effects
  • Updated translations for all supported languages to include new field labels

Rationale:

These changes streamline the user experience when importing models from Hugging Face by reducing the number of steps required. The additional form fields allow for more detailed model information to be captured during the import process.

Effects:

  • Users will now validate and submit the Hugging Face URL in a single step
  • Users can specify a model store folder name and service name when importing
  • The UI is cleaner and more straightforward, potentially reducing user confusion

Screenshots:

  • default
    image.png
  • valid URL
    image.png
  • invalid URL
    image.png

Checklist:

  • Documentation: Update user guide to reflect new import process and additional fields
  • Test case: Verify that URL validation occurs correctly on form submission
  • Test case: Ensure new fields (folder name and service name) are properly saved and utilized

Copy link

graphite-app bot commented Sep 20, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

agatha197 commented Sep 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing URL checking, we can remove more code related to URL checking such as huggingFaceURL state, isPendingCheck transition, hugginFaceModelInfo useUspenseTanQuery.

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 force-pushed the refactor/remove-checking-url-and-add-more-inputs branch from 70d208b to 9bc96f2 Compare September 20, 2024 23:47
@agatha197 agatha197 changed the base branch from feature/fetch-README-file-using-url to main September 20, 2024 23:47
@agatha197 agatha197 force-pushed the refactor/remove-checking-url-and-add-more-inputs branch from 9bc96f2 to e7da4b3 Compare September 21, 2024 00:36
Copy link
Contributor Author

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agatha197 agatha197 closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants