refactor: Use filterEmptyItem for table columns to improve readability.
#2815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.86% | 349/7185 |
| 🔴 | Branches | 4.44% | 220/4959 |
| 🔴 | Functions | 2.81% | 67/2382 |
| 🔴 | Lines | 4.75% | 334/7027 |
Test suite run success
96 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from f758c59
This was referenced Nov 5, 2024
agatha197
force-pushed
the
refactor/use-filterEmptyItem
branch
from
a7d80b1
to
226486e
Compare
agatha197
added
the
type:refactor
Graphite App
6 tasks
Merge activity
|
…ity. (#2815) Refactored image list column definitions to use conditional expressions with filterEmptyItem This PR simplifies the column definitions in CustomizedImageList and ImageList components by: - Replacing spread operator and conditional arrays with boolean expressions - Using filterEmptyItem to remove falsy column definitions - Maintaining the same functionality while reducing code complexity **Checklist:** - [ ] Documentation - [ ] Test case(s) to demonstrate the difference of before/after The changes make the code more maintainable by: 1. Eliminating nested conditional arrays 2. Making column visibility logic more explicit 3. Keeping column definitions flat and easier to read The functionality remains identical for users, with no changes to the UI or behavior.
yomybaby
force-pushed
the
refactor/use-filterEmptyItem
branch
from
226486e
to
f758c59
Compare
6 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored image list column definitions to use conditional expressions with filterEmptyItem
This PR simplifies the column definitions in CustomizedImageList and ImageList components by:
Checklist:
The changes make the code more maintainable by:
The functionality remains identical for users, with no changes to the UI or behavior.