fix: resizing column action causes order change in BAITable #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2024
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Nov 7, 2024
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
agatha197
force-pushed
the
feature/make-image-lists-resizable
branch
from
8fb21cb
to
679c83c
Compare
agatha197
force-pushed
the
fix/resizing-causes-order
branch
from
2dac546
to
9252f49
Compare
yomybaby
commented
Nov 11, 2024
yomybaby
force-pushed
the
fix/resizing-causes-order
branch
from
9252f49
to
85f75e2
Compare
yomybaby
changed the base branch from
feature/make-image-lists-resizable
to
main
Merge activity
|
Resolves #2830 Prevents column sorting when resizing columns in BAITable This PR fixes an issue where users could accidentally trigger column sorting while resizing table columns. It adds a debounced resize state check that temporarily disables click events during and shortly after column resizing operations. **Implementation details:** - Added `isResizing` state to track when a column is being resized - Implemented a 100ms debounced version of the resize state - Modified click handler to prevent column sorting when resize is in progress - Preserved original click behavior when not resizing
agatha197
force-pushed
the
fix/resizing-causes-order
branch
from
85f75e2
to
a888e3e
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.03% | 367/7294 |
| 🔴 | Branches | 4.4% | 221/5027 |
| 🔴 | Functions | 2.95% | 71/2408 |
| 🔴 | Lines | 4.93% | 352/7133 |
Test suite run success
100 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from a888e3e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2830
Prevents column sorting when resizing columns in BAITable
This PR fixes an issue where users could accidentally trigger column sorting while resizing table columns. It adds a debounced resize state check that temporarily disables click events during and shortly after column resizing operations.
Implementation details:
isResizingstate to track when a column is being resized