Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to formidable ^3.2.1 #1679

Closed
guimard opened this issue Jan 27, 2022 · 2 comments
Closed

Update to formidable ^3.2.1 #1679

guimard opened this issue Jan 27, 2022 · 2 comments

Comments

@guimard
Copy link

guimard commented Jan 27, 2022

Hi,

when trying to use formidable 3.2.1, tests passed except:

  320 passing (9s)
  5 pending
  7 failing

  1) Multipart
       #field(name, value)
         should set a multipart field value:
     AssertionError: expected Array [ 'tobi' ] to be 'tobi'
      at Assertion.fail (/usr/share/nodejs/should/cjs/should.js:281:17)
      at Assertion.value (/usr/share/nodejs/should/cjs/should.js:362:19)
      at /tmp/autopkgtest.4JRX27/autopkgtest_tmp/smokevEojgS/test/node/multipart.js:32:39
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

  2) Multipart
       #field(name, value)
         should work with file attachments:
     AssertionError: expected Array [ 'Tobi' ] to be 'Tobi'
      at Assertion.fail (/usr/share/nodejs/should/cjs/should.js:281:17)
      at Assertion.value (/usr/share/nodejs/should/cjs/should.js:362:19)
      at /tmp/autopkgtest.4JRX27/autopkgtest_tmp/smokevEojgS/test/node/multipart.js:46:30
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

  3) Multipart
       #attach(name, path)
         should attach a file:
     TypeError: Cannot read property 'should' of undefined
      at /tmp/autopkgtest.4JRX27/autopkgtest_tmp/smokevEojgS/test/node/multipart.js:70:31
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

  4) Multipart
       #attach(name, path, filename)
         should use the custom filename:
     TypeError: Cannot read property 'should' of undefined
      at /tmp/autopkgtest.4JRX27/autopkgtest_tmp/smokevEojgS/test/node/multipart.js:145:33
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5)

  5) Multipart
       #attach(name, path, filename)
         should fire progress event:
     Uncaught TypeError: Cannot read property 'should' of undefined
      at /tmp/autopkgtest.4JRX27/autopkgtest_tmp/smokevEojgS/test/node/multipart.js:166:33
      at Request.callback (/usr/share/nodejs/superagent/lib/node/index.js:890:12)
      at /usr/share/nodejs/superagent/lib/node/index.js:1122:18
      at zalgoSafe (/usr/share/nodejs/dezalgo/dezalgo.js:20:10)
      at f (/usr/share/nodejs/once/once.js:25:25)
      at IncomingForm.<anonymous> (/usr/share/nodejs/formidable/cjs/Formidable.js:227:11)
      at IncomingForm._maybeEnd (/usr/share/nodejs/formidable/cjs/Formidable.js:634:12)
      at /usr/share/nodejs/formidable/cjs/Formidable.js:413:18
      at WriteStream.<anonymous> (/usr/share/nodejs/formidable/cjs/PersistentFile.js:143:9)
      at finishMaybe (_stream_writable.js:639:14)
      at _stream_writable.js:616:5
      at WriteStream._final (internal/fs/streams.js:352:3)
      at callFinal (_stream_writable.js:609:10)
      at processTicksAndRejections (internal/process/task_queues.js:84:21)

  6) Multipart
       #field(name, val)
         should set a multipart field value:
     Uncaught AssertionError: expected Array [ 'foo' ] to be 'foo'
      at Assertion.fail (/usr/share/nodejs/should/cjs/should.js:281:17)
      at Assertion.value (/usr/share/nodejs/should/cjs/should.js:362:19)
      at /tmp/autopkgtest.4JRX27/autopkgtest_tmp/smokevEojgS/test/node/multipart.js:197:41
      at Request.callback (/usr/share/nodejs/superagent/lib/node/index.js:890:12)
      at /usr/share/nodejs/superagent/lib/node/index.js:1122:18
      at /usr/share/nodejs/dezalgo/dezalgo.js:17:12
      at RawTask.call (/usr/share/nodejs/asap/asap.js:40:19)
      at flush (/usr/share/nodejs/asap/raw.js:50:29)
      at processTicksAndRejections (internal/process/task_queues.js:79:11)

  7) Multipart
       #field(object)
         should set multiple multipart fields:
     Uncaught AssertionError: expected Array [ 'foo' ] to be 'foo'
      at Assertion.fail (/usr/share/nodejs/should/cjs/should.js:281:17)
      at Assertion.value (/usr/share/nodejs/should/cjs/should.js:362:19)
      at /tmp/autopkgtest.4JRX27/autopkgtest_tmp/smokevEojgS/test/node/multipart.js:212:41
      at Request.callback (/usr/share/nodejs/superagent/lib/node/index.js:890:12)
      at /usr/share/nodejs/superagent/lib/node/index.js:1122:18
      at /usr/share/nodejs/dezalgo/dezalgo.js:17:12
      at RawTask.call (/usr/share/nodejs/asap/asap.js:40:19)
      at flush (/usr/share/nodejs/asap/raw.js:50:29)
      at processTicksAndRejections (internal/process/task_queues.js:79:11)
@darakeon
Copy link

There is a vulnerability in the older version. Can this be updated?

https://nvd.nist.gov/vuln/detail/CVE-2022-29622

@titanism
Copy link
Collaborator

This is not a vulnerability. It was a false CVE.

See #1725 and related discussions. We are waiting for CVE to be removed or downgraded.

@ladjs ladjs locked as resolved and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants