-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added multiplier to type limits #118
feat: added multiplier to type limits #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TfedUD ,
I support making this change but it's not implemented correctly. Honeybee-energy ScheduleTypeLimits are objects that have their own properties. They are different from ScheduleTypeLimits in DOE-2 where it's really just a bit of text that denotes what the type is.
So, instead of:
elif type_limit == 'Multiplier'
it should be:
elif type_limit.display_name == 'Multiplier'
See here in the honeybee-energy docs for more guidance:
https://www.ladybug.tools/honeybee-energy/docs/honeybee_energy.schedule.typelimit.html
Hi @chriswmackey I didn't think type_limit had MULTIPLIER as an option. Would the Should the changes be your aforementioned, as well as adding multiplier to |
Hey @TfedUD , EnergyPlus does not have a |
Sorry about how late this edit was. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds an additional type limit to the
def schedule_type_limit_to_inp
to allow for MULTIPLIER type limits to pass