Develop #99
Merged
Develop #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Args: | ||
| model_file: Full path to a Honeybee Model file (HBJSON or HBpkl).""" | ||
| try: | ||
| print('This method is deprecated and you should use model-to-inp instead.') |
There was a problem hiding this comment.
I would use a DeprecationWarning here instead of print: https://docs.python.org/3/library/exceptions.html#DeprecationWarning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should officially bring the development branch to have the same capabilities as master. Everything in this PR has been tested with fully-detailed Revit sample models that were imported to eQuest without errors.
Furthermore, this PR includes several unit tests to make sure that individual objects are being translated to INP correctly.