Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(l2_token_addr): add a function to get the l2 token addr #128

Merged
merged 1 commit into from
Aug 14, 2024
Merged

feat(l2_token_addr): add a function to get the l2 token addr #128

merged 1 commit into from
Aug 14, 2024

Conversation

fborello-lambda
Copy link

@fborello-lambda fborello-lambda commented Aug 14, 2024 •
edited
Loading

Purpose

  • Provide a low level implementation to interact with the L2SharedBridge in order to get the L2 Token Address from the L1 token Address

@fborello-lambda fborello-lambda marked this pull request as ready for review August 14, 2024 19:31
ilitteri
ilitteri approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If I'm not mistaken, the test will only pass with your network config, but no worries, we'll handle the tests later.

@ilitteri ilitteri merged commit 25883f6 into zksync-ethers-rs-v1 Aug 14, 2024
1 of 5 checks passed
@ilitteri ilitteri deleted the fd-get-l2-token-addr branch August 14, 2024 19:34
@fborello-lambda fborello-lambda mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilitteri ilitteri ilitteri approved these changes

@ManuelBilbao ManuelBilbao Awaiting requested review from ManuelBilbao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fborello-lambda @ilitteri