Option for ignoring the Content-Range header

[Stadly]

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	yes
RFC	no
QA	no

Description

When the response body has already been limited to the requested range, the emitter should ignore the Content-Range header and emit the full response body.

Fixes #22

[lcobucci]

Based on the discussion in #22, I'd say it makes more sense to provide an alternative implementation instead of modifying the existing one.

I'd be fine with reorganising SapiStreamEmitter to provide some decoration but having a different behaviour based on a boolean constructor parameter isn't a very maintainable/extensible design IMHO.

[Stadly]

Any other opinions? I'm fine with either:

1. Modify SapiStreamEmitter (as done in this PR).
2. Create a separate emitter.
3. Fix the memory issue in SapiEmitter. That would also fix SapiStreamEmitter that does not consider Content-Range #22, as Content-Range is already ignored by SapiEmitter. I think this is my preferred option. Or is there a reason why SapiEmitter converts the whole response body to a string and emits it in a single go instead of emitting it as smaller chunks? With the current implementation of SapiEmitter, the entire response body must be written to memory, which does not work for large responses.