Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pass meta data along with push notifications #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Stalinko
Copy link

@Stalinko Stalinko commented Oct 8, 2021

This PR replicates this one but without it's issues: #49
I'll just copy the description:

Pusher Beams allows passing meta data along with message parameters: https://pusher.com/docs/beams/guides/publishing-to-multiple-devices#adding-metadata-to-a-notification

I'm using that in my project and decided to format as a handy API in PusherMessage class.
Tests added.
Also added .idea folder into .gitignore. It's created by PHPStorm.

@Stalinko
Copy link
Author

Stalinko commented Oct 8, 2021

styleci again alerts something but I can't understand what it wants. Do I have to fix anything again?

@hypnocill
Copy link

@Stalinko I see that a ton of time has passed but any idea if this PR will ever be merged or we are supposed to patch the library with the diff ourselves?

@Stalinko
Copy link
Author

@hypnocill for some reason the maintainer of this project doesn't react at my PRs, seems like he abandoned it.

@themsaid @freekmurze @atymic what's the state of this project? Would you have some time to accept the PRs?

@hypnocill
Copy link

@Stalinko I see, thanks for answering. How did you proceed, did you patch the library yourself, forked it or found another one?

@Stalinko
Copy link
Author

@hypnocill you can use my fork (https://github.com/Stalinko/pusher-push-notifications/tree/meta-data) directly in composer until this PR is accepted.
This is how I do it.

In composer.json inside require write this:

    "laravel-notification-channels/pusher-push-notifications": "dev-meta-data",

and also add this block to the end of the file:

  "repositories": [
    {
      "url": "https://github.com/Stalinko/pusher-push-notifications",
      "type": "git"
    }
  ]

@hypnocill
Copy link

hypnocill commented Jun 17, 2022

@Stalinko
Thank you so much! I'll consider that or I'll make a local patch or fork because there are two other things I may need - making the beams instance public and having the library install for laravel 6 since now it doesn't due to the requiring of laravel/events 7+, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants