Beautify Livewire Stack #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jubeki
reviewed
Oct 28, 2023
Comment on lines
+5
to
+6
| $logout = function (Logout $logout) { | ||
| $logout(); |
There was a problem hiding this comment.
Suggested change
| $logout = function (Logout $logout) { | |
| $logout(); | |
| $logout = function (Logout $logoutAction) { | |
| $logoutAction(); |
In my opinion it is a bad idea to have the same name for the callback and action, because I thought the Closure is calling itself.
Comment on lines
+27
to
+28
| $logout = function (Logout $logout) { | ||
| $logout(); |
There was a problem hiding this comment.
Suggested change
| $logout = function (Logout $logout) { | |
| $logout(); | |
| $logout = function (Logout $logoutAction) { | |
| $logoutAction(); |
lancechentw
added a commit
to lancechentw/breeze
that referenced
this pull request
Feb 20, 2024
The property names were not changed correspondingly to the refactors from laravel#326.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring PR to clean up some code duplication in the Livewire stack as well as extract the complicated login logic into a Livewire Form. Also adds comments on class based stack.