Added expand option to Subscription latestInvoice() #1548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this is a breaking change to the method signature. Anyone overwriting it will see their apps break. We can do this in 15.x (master) if you want to. |
|
OK, I see. I'll open a PR in the master branch then. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non breaking change, added expand option to the
latestInvoice()method of theSubscriptionclassThis is useful as when getting the latest invoice to check for 'requires_action' 3DS it's helpful to be able to return the payment intent. We could also have a method on the Invoice,
requiresConfirmation()Invoice
pay()does not throw anIncompletePaymentexception, it throws a native StripeCardExceptionso the payment intent is not in the error object