Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring names for the stripe_id column on Cashier models. #1657

Closed
wants to merge 4 commits into from

Conversation

kylearch
Copy link

This PR allows for using a column other than stripe_id on the various Cashier models.

It replaces all uses of ->stripe_id with ->stripeId() which can be found in the new HasStripeId trait. This trait is included alongside the other traits in the Billable trait, and in the Subscription and SubscriptionItem models.

To make use of it, you would simply define the model's public static function stripeIdColumn() method to return whatever column name your model uses (including custom Subscription and SubscriptionItem models that extend their Cashier counterparts).

The purpose of this PR was so that in a project of mine I could use my custom models that mirror their actual Stripe counterparts 1:1 in my database. This allows me to both match the Stripe object schema and also more closely follow the Laravel/Eloquent schema pattern (in this case using id instead of stripe_id for the User [Customer], Subscription, and SubscriptionItem models).

@driesvints
Copy link
Member

I'm sorry but I don't think we want to take up the maintenance burden of this. If you really need this it's best that you fork the library.

@driesvints driesvints closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants