-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Failing Event Meter tests #1708
Conversation
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
@driesvints This seems to have fixed it |
strange thing is, checks pass on my repo, but then once you merge it it fails |
Gonna give this a go. Thanks! |
Still one failing it seems: https://github.com/laravel/cashier-stripe/actions/runs/10471014163/job/28997392263 |
I'm not sure why this happens only on merge, maybe there's network latency that's intensified depending on the server running the tests, which could explain why sleep() works, about the only "solution" I can think of is to add another sleep function before we query the event summary on line 105, I wish I had more insights, but at this stage is just educated guesses |
I'll need to revert all of this unfortunately since we're out of time. Need to do releases today and we can't ship this without passing tests, I'm sorry about that. I still very much would like to get this in but we'll need to figure out why this was failing. I unfortunately don't have the time to deep dive into this. |
This reverts commit 52d43bc.
No problem I understand, I'll keep trying, I'll send a PR with more sleep statements after the release and see if that fixes anything, if not, I'll use AWS to spin up multiple instances and try to see if I can reproduce it on any of them. |
this is a work in progress