Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing Event Meter tests #1708

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Fix Failing Event Meter tests #1708

merged 3 commits into from
Aug 20, 2024

Conversation

Bark-fa
Copy link
Contributor

@Bark-fa Bark-fa commented Aug 19, 2024

this is a work in progress

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@Bark-fa
Copy link
Contributor Author

Bark-fa commented Aug 19, 2024

@driesvints This seems to have fixed it

@Bark-fa
Copy link
Contributor Author

Bark-fa commented Aug 19, 2024

strange thing is, checks pass on my repo, but then once you merge it it fails

@driesvints driesvints marked this pull request as ready for review August 20, 2024 11:53
@driesvints
Copy link
Member

Gonna give this a go. Thanks!

@driesvints driesvints merged commit 52d43bc into laravel:15.x Aug 20, 2024
9 checks passed
@driesvints
Copy link
Member

Still one failing it seems: https://github.com/laravel/cashier-stripe/actions/runs/10471014163/job/28997392263
I also can't reproduce it locally..

@Bark-fa
Copy link
Contributor Author

Bark-fa commented Aug 20, 2024

I'm not sure why this happens only on merge, maybe there's network latency that's intensified depending on the server running the tests, which could explain why sleep() works, about the only "solution" I can think of is to add another sleep function before we query the event summary on line 105, I wish I had more insights, but at this stage is just educated guesses

@driesvints
Copy link
Member

I'll need to revert all of this unfortunately since we're out of time. Need to do releases today and we can't ship this without passing tests, I'm sorry about that. I still very much would like to get this in but we'll need to figure out why this was failing. I unfortunately don't have the time to deep dive into this.

driesvints added a commit that referenced this pull request Aug 20, 2024
@Bark-fa
Copy link
Contributor Author

Bark-fa commented Aug 20, 2024

No problem I understand, I'll keep trying, I'll send a PR with more sleep statements after the release and see if that fixes anything, if not, I'll use AWS to spin up multiple instances and try to see if I can reproduce it on any of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants