Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] PHP 8.4 build #52633

Draft
wants to merge 47 commits into
base: 11.x
Choose a base branch
from
Draft

[11.x] PHP 8.4 build #52633

wants to merge 47 commits into from

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Sep 3, 2024

Blocked by:

@driesvints
Copy link
Member Author

Builds now fail due to a Redis issue:

php: symbol lookup error: /usr/lib/php/20230901/redis.so: undefined symbol: php_rand

@driesvints
Copy link
Member Author

725 deprecations, 10 errors and 8 failures on the PHPUnit v11 build 👀

* Fix implicit null types

* Update some lower requirements

* Fix typo

* More lower version constraints

* More lower version constraints

* For now only run lowest strategy

* Adjust PHPunit version

* Adjust carbon requirement

* Add phpunit 10 again

* Fix phpunit annotations

* Add prefer-stable again, disable fail-fast

* Allow cli-parser 2.0.1 for phpunit 10

* Escape pipe
* Update sebastian/exporter

* Update dependencies for PHP 8.4

* Update dependencies for PHP 8.4

* Update dependencies for PHP 8.4

* run both phpunits version on lowest and stable again

* Disable fail-fast

* Update required predis/predis

* Bump vlucas/phpdotenv

* bump guzzlehttp/promises

* Bump league/flysystem

* wip

* wip

* wip

---------

Co-authored-by: Dries Vints <dries@vints.be>
@driesvints driesvints changed the title PHP 8.4 build [11.x] PHP 8.4 build Sep 5, 2024
crynobone and others added 19 commits September 20, 2024 08:35
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@Jubeki
Copy link
Contributor

Jubeki commented Sep 24, 2024

I tried creating a PR for aws/aws-sdk-php regarding the implicit nullable type which adds a lot of deprecations in this Test Suite:

It was closed because it was regarded a breaking change. Do you have any way to talk to them or would you try another PR?
(This would not really be a blocker, but would result in many deprecations)

PR was merged, after some discussions.

@crynobone
Copy link
Member

Do you have any way to talk to them or would you try another PR?

We are identifying which dependencies need a new version to be compatible with PHP 8.4. Some large projects might need extra work and probably wait for the beta/stable release of PHP 8.4 before making those changes.

crynobone and others added 22 commits September 25, 2024 09:13
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
* Bump aws/aws-sdk-php for PHP 8.4

* Revert some unrelated changes
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
This reverts commit 4192402.
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants