Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add octane.roadrunner.config_version settings to roadrunner start binary #822

Closed
wants to merge 2 commits into from
Closed

Add octane.roadrunner.config_version settings to roadrunner start binary #822

wants to merge 2 commits into from

Conversation

ValikoDorodnov
Copy link

@ValikoDorodnov ValikoDorodnov commented Jan 22, 2024

For more comfortable developing i add an opportunity to set RoadRunner version via config.

UPD

Also add:

  • logs.mode
  • logs.output
  • logs.encoding

@ValikoDorodnov ValikoDorodnov changed the title Add octane.roadrunne.config_version settings to roadrunner start binary Add octane.roadrunner.config_version settings to roadrunner start binary Jan 22, 2024
Add
logs.mode
logs.output
logs.encoding

via config
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@ValikoDorodnov
Copy link
Author

@taylorotwell
Thank you for your feedback, Taylor!

For this implementation, I used the same approach that is used on line

src/Commands/StartRoadRunnerCommand.php:88

The function config() is standard for the Laravel library.

I think developers need to give the ability to manage parameters:

  • version
  • logs.mode
  • logs.output
  • logs.encoding

I checked the build functionality, and it seems to be in order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants