Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow debug in CADDY_GLOBAL_OPTIONS #892

Closed
wants to merge 3 commits into from
Closed

Allow debug in CADDY_GLOBAL_OPTIONS #892

wants to merge 3 commits into from

Conversation

chu121su12
Copy link
Contributor

This PR let debug option to be appended in CADDY_GLOBAL_OPTIONS. See https://caddyserver.com/docs/caddyfile/options#debug

dunglas
dunglas reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, to simplify the code, we could introduce more environment variables for these options (like DEBUG and AUTO_HTTPS).

src/Commands/StartFrankenPhpCommand.php Outdated Show resolved Hide resolved
@chu121su12
Copy link
Contributor Author

AUTO_HTTPS is already part of http-redirect. Added server-debug option only for FrankenPHP for now

@taylorotwell
Copy link
Member

I would actually like to see these become env vars otherwise we may end up with a lot of FrankenPHP specific CLI options?

@taylorotwell taylorotwell marked this pull request as draft May 17, 2024 22:07
@driesvints
Copy link
Member

Going to close this one now as it seems stale. Feel free to resend this once you've made the necessary changes, thanks.

@driesvints driesvints closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chu121su12 @taylorotwell @driesvints @dunglas