Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a way to define frankenphp version #976

Conversation

pushpak1300
Copy link

@pushpak1300 pushpak1300 commented Dec 22, 2024

Recently, due to an issue with FrankenPHP (see issue #1276), the install command was temporarily non-functional.

I believe there should be a way to specify the underlying FrankenPHP version in the install command. This would allow us to use a specific version if there are problems with the underlying worker servers.

Let me know if you not happy with the current implementation as I can change implementation to pass the worker server version from the command itself.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants