Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust headers for users and articles #1122

Open
driesvints opened this issue Aug 28, 2024 · 9 comments
Open

Adjust headers for users and articles #1122

driesvints opened this issue Aug 28, 2024 · 9 comments

Comments

@driesvints
Copy link
Member

Make them not page wide but a rectangle image above the page.

@tauseefsshah
Copy link
Contributor

Not page wide but a rectangle

@driesvints Do you mean something like this for articles?

image

@driesvints
Copy link
Member Author

No, more a rectangle that's the width of the viewing area of the article. Maybe page-wide isn't the right word but more something like not viewport-wide.

@tauseefsshah
Copy link
Contributor

@driesvints How about this?

image

@driesvints
Copy link
Member Author

looks good! Can we maybe move the text back into the image like we have now?

@tauseefsshah
Copy link
Contributor

image

image

@driesvints
Copy link
Member Author

Beautiful! Thank you for this 😄

@tauseefsshah
Copy link
Contributor

You're welcome! This is how the users.profile view looks with boxed header
image

@driesvints Should I keep it page-wide (existing) or boxed (image above)?

@driesvints
Copy link
Member Author

Boxed, thanks!

@tauseefsshah
Copy link
Contributor

PR for this - #1140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants