UPDATE - Header in articles.show and users.profile view to be boxed #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks really good already. I'm wondering if we can pin the "back to articles" more to the top so the left and top padding is the same. And also pin the rest to the bottom of the box so the left and bottom padding is the same. For the article header that is. |
|
Article header with equal padding
@driesvints Quick question - Is there a reason we are not showing |
|
@tauseefsshah looks perfect really. Actually I don't remember. I think we can re-add it now. Can you do that? Then this PR is gtg 🚀 |
|
@driesvints Done 🚀 |
|
Amazing, thanks for your help! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1122