Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metadata handling to per-format file. #94

Open
larsbrinkhoff opened this issue Nov 6, 2021 · 2 comments
Open

Move metadata handling to per-format file. #94

larsbrinkhoff opened this issue Nov 6, 2021 · 2 comments

Comments

@larsbrinkhoff
Copy link
Owner

There is currently an info.c blob which parses metadata from various file formats. The _info functions should be moved to the appropriate files, and struct pdp10_file should have a new function pointer that refers to those functions. This is currently not trivial because the various _info functions get different parameters.

@larsbrinkhoff
Copy link
Owner Author

Actually, why have a separate info function at all? I was thinking the dump tool could just call the read function to build a core image and skip the info function. But now I have dump also pass metadata to the target file so it does need the info call. So it might just as well be done from the read function.

@larsbrinkhoff
Copy link
Owner Author

Speaking of metadata, any additional mystery words (see #92) could be regarded as metadata to paste onto the end of the target file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant