Fix getFolderPath of HookOpenFL for mobile build #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you're using the #mobile pathway, have you tested it for iOS as well as android? |
|
No, I didn't. Sorry. I'm able to run test ios on Windows successfully (it generates the xcodeproj files), but since I don't have a Mac, I'm not able to complete the build process. Since this is a compile time error, I believe the fix should work for iOS too (or, in another way, the error without the fix should occur for iOS too). |
|
No problem, I'll probably merge this tomorrow then. (I'm not easily able to test on iOS either). If it's broken on iOS, presumably someone will tell us! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function getFolderPath have some wrong function signatures in mobile branch.
When building from master (Haxe 3.4.7 / OpenFL 8.6.4 / Lime 7.1.1 / Windows 10) for android, it gives me the following error:
I fixed it using the other case in the same line then it gives me the following:
The changes in this PR fixes these issues and the build goes fine!