Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More testing #139

Merged
merged 18 commits into from
Aug 28, 2024
Merged

More testing #139

merged 18 commits into from
Aug 28, 2024

Conversation

lasuillard
Copy link
Owner

Improve test coverage & quality.

Recreated PR #138.

@lasuillard lasuillard added the enhancement New feature or request label Aug 24, 2024
@lasuillard lasuillard self-assigned this Aug 24, 2024
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.92%. Comparing base (e828df4) to head (74c2515).

✅ All tests successful. No failed tests found.

Files Patch % Lines
src/lib/search.ts 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   88.55%   89.92%   +1.36%     
==========================================
  Files          43       39       -4     
  Lines        1127     1032      -95     
  Branches      101       91      -10     
==========================================
- Hits          998      928      -70     
+ Misses         31       14      -17     
+ Partials       98       90       -8     
Flag Coverage Δ
unit 89.92% <92.00%> (+1.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Aug 24, 2024

Bundle Report

Changes will decrease total bundle size by 3.89kB ⬇️

Bundle name Size Change
lasuillard.github.io-esm 376.9kB 3.89kB ⬇️

@lasuillard lasuillard marked this pull request as ready for review August 28, 2024 12:01
@lasuillard lasuillard merged commit fea6bb2 into main Aug 28, 2024
10 checks passed
@lasuillard lasuillard deleted the X-testing-20240824 branch August 28, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant