Skip to content
lint

fix: client init state should not regress when data source interrupted #1815

Sign in to view logs

fix: client init state should not regress when data source interrupted

fix: client init state should not regress when data source interrupted #1815

Triggered via pull request September 30, 2024 21:42
@cwaldren-ldcwaldren-ld
synchronize #441
cw/sdk-727/wrong-initialized-condition
Status Success
Total duration 2m 27s
Artifacts –

cpp-linter.yml

on: pull_request
cpp-linter
2m 6s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
/home/runner/boost/boost/boost/include/boost/smart_ptr/detail/shared_count.hpp:612:26 [clang-analyzer-cplusplus.NewDelete]: home/runner/boost/boost/boost/include/boost/smart_ptr/detail/shared_count.hpp#L612
Use of memory after it is freed
/libs/client-sdk/src/client_impl.cpp:203:37 [bugprone-unchecked-optional-access]: libs/client-sdk/src/client_impl.cpp#L203
unchecked access to optional value
/libs/client-sdk/src/client_impl.cpp:238:51 [bugprone-easily-swappable-parameters]: libs/client-sdk/src/client_impl.cpp#L238
2 adjacent parameters of 'VariationInternal' of convertible types are easily swapped by mistake
/libs/client-sdk/src/client_impl.cpp:294:25 [bugprone-unchecked-optional-access]: libs/client-sdk/src/client_impl.cpp#L294
unchecked access to optional value
/libs/client-sdk/src/client_impl.hpp:31:5 [readability-inconsistent-declaration-parameter-name]: libs/client-sdk/src/client_impl.hpp#L31
function 'launchdarkly::client_side::ClientImpl::ClientImpl' has a definition with different parameter names
/libs/internal/src/../include/launchdarkly/data_sources/data_source_status_manager_base.hpp:135:13 [clang-analyzer-cplusplus.NewDeleteLeaks]: libs/internal/src/../include/launchdarkly/data_sources/data_source_status_manager_base.hpp#L135
Potential memory leak
/libs/client-sdk/src/client_impl.hpp:87:5 [cppcoreguidelines-explicit-virtual-functions: libs/client-sdk/src/client_impl.hpp#L87
annotate this function with 'override' or (rarely) 'final'
/libs/client-sdk/src/client_impl.hpp:102:36 [readability-identifier-length]: libs/client-sdk/src/client_impl.hpp#L102
parameter name 'fn' is too short, expected at least 3 characters
/libs/client-sdk/src/data_sources/data_source_status.cpp:37:24 [bugprone-unchecked-optional-access]: libs/client-sdk/src/data_sources/data_source_status.cpp#L37
unchecked access to optional value
cpp-linter
The following actions use a deprecated Node.js version and will be forced to run on node20: MarkusJx/install-boost@v2.4.4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/