Skip to content

fix: guard against overflow in sse backoff calculation #1891

fix: guard against overflow in sse backoff calculation

fix: guard against overflow in sse backoff calculation #1891

Triggered via pull request October 8, 2024 21:21
Status Success
Total duration 1m 8s
Artifacts

cpp-linter.yml

on: pull_request
cpp-linter
54s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

1 error, 10 warnings, and 1 notice
/libs/server-sent-events/src/backoff.cpp:58:15 [performance-unnecessary-value-param]: libs/server-sent-events/src/backoff.cpp#L58
parameter 'random' is passed by value and only copied once; consider moving it to avoid unnecessary copies
/libs/server-sent-events/src/backoff_detail.cpp:16:9 [bugprone-narrowing-conversions: libs/server-sent-events/src/backoff_detail.cpp#L16
narrowing conversion from 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'double'
/libs/server-sent-events/src/backoff_detail.cpp:16:48 [bugprone-narrowing-conversions: libs/server-sent-events/src/backoff_detail.cpp#L16
narrowing conversion from 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'double'
Run clang-format on libs/server-sent-events/src/backoff_detail.cpp: libs/server-sent-events/src/backoff_detail.cpp#L1
File libs/server-sent-events/src/backoff_detail.cpp does not conform to Custom style guidelines. (lines 29)