Skip to content
lint

fix: guard against overflow in sse backoff calculation #1897

Sign in to view logs

fix: guard against overflow in sse backoff calculation

fix: guard against overflow in sse backoff calculation #1897

Triggered via pull request October 8, 2024 22:11
@cwaldren-ldcwaldren-ld
synchronize #455
cw/sdk-757-backoff-overflow
Status Success
Total duration 1m 7s
Artifacts –

cpp-linter.yml

on: pull_request
cpp-linter
55s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
/libs/server-sent-events/src/backoff.cpp:44:18 [modernize-pass-by-value]: libs/server-sent-events/src/backoff.cpp#L44
pass by value and use std::move
/libs/server-sent-events/src/backoff.cpp:58:15 [performance-unnecessary-value-param]: libs/server-sent-events/src/backoff.cpp#L58
parameter 'random' is passed by value and only copied once; consider moving it to avoid unnecessary copies
/libs/server-sent-events/src/backoff.hpp:54:5 [modernize-use-nodiscard]: libs/server-sent-events/src/backoff.hpp#L54
function 'delay' should be marked [[nodiscard]]
/libs/server-sent-events/src/backoff_detail.cpp:20:34 [bugprone-narrowing-conversions: libs/server-sent-events/src/backoff_detail.cpp#L20
narrowing conversion from 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'double'
/libs/server-sent-events/src/backoff_detail.cpp:20:59 [bugprone-narrowing-conversions: libs/server-sent-events/src/backoff_detail.cpp#L20
narrowing conversion from 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'double'
/libs/server-sent-events/src/backoff_detail.cpp:24:33 [bugprone-easily-swappable-parameters]: libs/server-sent-events/src/backoff_detail.cpp#L24
2 adjacent parameters of 'delay' of similar type ('const std::chrono::milliseconds') are easily swapped by mistake
/libs/server-sent-events/src/backoff_detail.cpp:27:33 [bugprone-easily-swappable-parameters]: libs/server-sent-events/src/backoff_detail.cpp#L27
2 adjacent parameters of 'delay' of convertible types are easily swapped by mistake
/libs/server-sent-events/tests/backoff_test.cpp:14:35 [cppcoreguidelines-avoid-magic-numbers: libs/server-sent-events/tests/backoff_test.cpp#L14
1000 is a magic number; consider replacing it with a named constant
/libs/server-sent-events/tests/backoff_test.cpp:14:68 [cppcoreguidelines-avoid-magic-numbers: libs/server-sent-events/tests/backoff_test.cpp#L14
30000 is a magic number; consider replacing it with a named constant
/libs/server-sent-events/tests/backoff_test.cpp:15:35 [cppcoreguidelines-avoid-magic-numbers: libs/server-sent-events/tests/backoff_test.cpp#L15
60000 is a magic number; consider replacing it with a named constant